@[email protected] to Programmer [email protected]English • 10 months agoadvancedlemmy.worldimagemessage-square32fedilinkarrow-up1429arrow-down115
arrow-up1414arrow-down1imageadvancedlemmy.world@[email protected] to Programmer [email protected]English • 10 months agomessage-square32fedilink
minus-square@[email protected]linkfedilink9•10 months agoIf you’re in a language that supports it, please don’t use if (false) use if ($disallowAllUsers = false && $whateverTheRealConditionIs)
minus-square@[email protected]linkfedilink6•10 months agoNever seen this, what language or buildsystem is this?
minus-square@[email protected]linkfedilink3•edit-210 months agoThat specific language is PHP, but the tip is applicable in any language that supports inline assignment.
minus-squareThe Octonautlinkfedilink6•10 months agoif (true === $wantToCauseErrorsForFun) { badOldFunction(); }
minus-squareKogasalink1•10 months agoThe assignment syntax is too close to comparison, which is what is more typical in that position. I would recommend const bool _isFeatureEnabled = false; if (_isFeatureEnabled && ...) if not a proper feature flag (or just remove the code).
minus-square@[email protected]linkfedilink-1•10 months agoIt seems much worse to use a setter in an if statement.
minus-square@[email protected]linkfedilink0•10 months agoThink of it as inline attribution/documentation.
If you’re in a language that supports it, please don’t use
if (false)useif ($disallowAllUsers = false && $whateverTheRealConditionIs)Never seen this, what language or buildsystem is this?
That specific language is PHP, but the tip is applicable in any language that supports inline assignment.
The assignment syntax is too close to comparison, which is what is more typical in that position. I would recommend
const bool _isFeatureEnabled = false; if (_isFeatureEnabled && ...)if not a proper feature flag (or just remove the code).
It seems much worse to use a setter in an if statement.
Think of it as inline attribution/documentation.