• douglasg14b
    link
    fedilink
    English
    arrow-up
    4
    ·
    5 months ago

    Yeah, and electron already has a secureStorage API that handles the OS interop for you. Which signal isn’t using, and a PR already exists to enable…

    • punkcoder@lemmy.world
      link
      fedilink
      English
      arrow-up
      5
      ·
      5 months ago

      I’m not surprised… I think people (‘the ones that care at least’) would be horrified to know how much of this stuff slips through, because it’s hard (there are so many other things that are pulling at developers that something falls through the cracks). Most of the time the right answer is to bring it up. Then thank them when they resolve the issue (with beer and pizza money at the very least).

      Looks like it’s waiting for approval, https://github.com/signalapp/Signal-Desktop/pull/6933 for anyone else thats interested.