• BrikoX
    link
    fedilink
    English
    923 hours ago

    You have to make a fork aka copy and modify to contribute via pull requests. The license is fundamentally broken.

    • @sweng
      link
      -123 hours ago

      Yes, but that has nothing to do with Github TOS. It does not require you to accept or even allow pull requests.

      • chebra
        link
        fedilink
        423 hours ago

        @sweng @BrikoX No, the TOS “just” says that by making the repo public you are granting all github users the right to fork it. So that right has already been granted.

        • @sweng
          link
          423 hours ago

          The TOS actually does not say you are granting users permissions to fork in the usually understood sense. The TOS gives you permission to copy, which Github calls “forking” even though it isn’t.

          • chebra
            link
            fedilink
            522 hours ago

            @sweng

            > you agree to allow others to view and “fork” your repositories

            How did you come to the conclusion that this does not grant the permissions to fork? It’s literally in the sentence. Where else did you find the definition of “forking”, if not here? This is what Github defines in the TOS, this is the label on the button in github UI, so clearly this is also what winamp means when they forbid “forking” and that means it’s against the TOS. There is no other “forking”.

            • @sweng
              link
              3
              edit-2
              22 hours ago

              I got it from the TOS:

              By setting your repositories to be viewed publicly, you agree to allow others to view and “fork” your repositories (this means that others may make their own copies of Content from your repositories in repositories they control).

              They explicitly define it as making copies. There is no mention of being allowed to modify said copy. Also note the quotes around “fork”, since it differs from the usual definition.

              E.g. wikpedia (https://en.m.wikipedia.org/wiki/Fork_(software_development) defines it thusly:

              In software engineering, a project fork happens when developers take a copy of source code from one software package and start independent development on it, creating a distinct and separate piece of software.

              (Emphasis mine)

              • chebra
                link
                fedilink
                022 hours ago

                @sweng But what else would “forking” mean? As you said “in the usual sense”. This is the usual sense - making a copy of the repo on github = forking.

                • @sweng
                  link
                  522 hours ago

                  I edited my reply to include the definition from Wikipedia, but there are of course many other sources.

      • BrikoX
        link
        fedilink
        English
        223 hours ago

        I’m not sure if it’s spelled out in the ToS, but there is no way to prevent pull requests on public repos, it’s a functional requirement.

        • chebra
          link
          fedilink
          323 hours ago

          @BrikoX @sweng

          It’s in the linked issue, spelled out alright:

          > By setting your repositories to be viewed publicly, you agree to allow others to view and “fork” your repositories (this means that others may make their own copies of Content from your repositories in repositories they control).

        • @sweng
          link
          123 hours ago

          Just because you can do something, does not mean you are allowed to.