Brilliant exception handling I found in an app i had to work on

  • chillhelm@lemmy.world
    link
    fedilink
    arrow-up
    5
    ·
    1 year ago

    Depending on the language it either does nothing and just adds code bloat or (and this would be much worse) it will catch any exception that can be implicitly cast to type Exception and throw it as type Exception. So the next higher scope would not be able to catch e.g. a RuntimeException or w.e. to handle appropriately. It could only catch a regular Exception even if the original error was a more detailed type.

    • StudioLE
      link
      fedilink
      arrow-up
      2
      ·
      1 year ago

      It’s C# so it’s just rethrowing the original exception.

      It might also be messing with the stack trace though which can be a bit frustrating for future debugging. But that’s only a vague recollection of something I read in the past so I could be wrong

      • Pieisawesome@lemmy.world
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        Throwing exceptions are very costly due to the stack trace, so building the stack trace twice will cause a big performance hit

        • TwilightKiddy
          link
          fedilink
          English
          arrow-up
          4
          ·
          edit-2
          1 year ago

          Correct me if I’m wrong, but this will actually cut the stack trace and then start another one from your try-catch block, which is an evil thing to do towards those who will actually read your stack traces. To preserve the stack trace you do throw;, not throw ex;, and I’m assuming IDE is underlining that statement exactly for this reason.

          • Pieisawesome@lemmy.world
            link
            fedilink
            English
            arrow-up
            1
            ·
            1 year ago

            Yes, hence why I mentioned it collects the stack trace twice.

            It’s more than just more difficult for debugging