Brilliant exception handling I found in an app i had to work on

  • StudioLE
    link
    fedilink
    arrow-up
    2
    ·
    2 years ago

    It’s C# so it’s just rethrowing the original exception.

    It might also be messing with the stack trace though which can be a bit frustrating for future debugging. But that’s only a vague recollection of something I read in the past so I could be wrong

    • Pieisawesome@lemmy.world
      link
      fedilink
      arrow-up
      1
      ·
      2 years ago

      Throwing exceptions are very costly due to the stack trace, so building the stack trace twice will cause a big performance hit

      • TwilightKiddy
        link
        fedilink
        English
        arrow-up
        4
        ·
        edit-2
        2 years ago

        Correct me if I’m wrong, but this will actually cut the stack trace and then start another one from your try-catch block, which is an evil thing to do towards those who will actually read your stack traces. To preserve the stack trace you do throw;, not throw ex;, and I’m assuming IDE is underlining that statement exactly for this reason.

        • Pieisawesome@lemmy.world
          link
          fedilink
          English
          arrow-up
          1
          ·
          2 years ago

          Yes, hence why I mentioned it collects the stack trace twice.

          It’s more than just more difficult for debugging