• BB_C
    link
    fedilink
    arrow-up
    5
    arrow-down
    1
    ·
    1 year ago

    If the matches are causing too much nesting/rightward drift, then that could be an indicator that you’re doing something wrong.

    If it’s the opposite, then you’re probably doing something right, except maybe the code needs some refactoring if there is too much clutter.

    If there isn’t much difference, then it’s a matter of style. I for example sometimes prefer to match on bools in some contexts because it makes things look clearer to me, despite it being not the recommended style. I’m also a proud occasional user of bool::then() and bool::then_some() 😉

    Also, if you find yourself often wishing some API was available for types like bool, Option, and Result, then you don’t have to wish for long. Just write some utility extension traits yourself! I for example have methods like bool::err_if(), bool::err_if_not(), Option::none_or_else(), and some more tailored to my needs methods, all available via extension traits.

    Macros can also be very useful, although some people go for them too early. So if everything else fails to declutter your code, try writing a macro or two.

    And it’s worth remembering, there is no general rule, other than if the code is understandable for you and works, then you’re probably okay irregardless of style. It’s all sugar after all, unless you’re really doing some glaringly wrong stuff.