Sometimes unused class or function manages to slip into code base. Static code checkers like ruff, flake8 does not have rules for detecting such globally unused code.

I tried using vulture, but it has too many false positives to have it as part of CI/CD pipeline.

I have tried to implement my own, more reliable check for global deadcode detection.

Please let me know what you think about it.

  • qwop
    link
    fedilink
    English
    arrow-up
    2
    ·
    1 year ago

    From a quick look at the code it looks like it uses regex to extract any name assignments and compares that to usages. This approach seems very limited as it has no understanding of context (e.g. the same name used in multiple places, or special methods like __add__ on classes that aren’t called manually).

    I’d be interested to know what false positives in vulture this solves. The main false positives I’ve found with vulture are:

    • Names that are publicly exposed in a library but not actually used
    • Methods in classes that are called by an external parent class defined in some external module.
    • Special cases (for example unittest functions, which aren’t called manually, or fastapi route decorator functions)

    I don’t think this project would solve any of those cases (and in some cases I think vulture has special casing to handle things better).

    • niekasOP
      link
      fedilink
      English
      arrow-up
      2
      ·
      edit-2
      1 year ago

      Yes, you are right 👍 Thanks for pointing this out. And yes, my package is only a subset of vulture functionality.