• toastal@lemmy.ml
    link
    fedilink
    arrow-up
    7
    arrow-down
    2
    ·
    8 months ago

    I dislike that JavaScript is required… not just for best experience or functionality, but literally to get a non-blank page. Not even a <noscript> is left.

    One of the failures I think of all of these forges is they keep trying to tackle getting users by posing moral arguments instead of technical ones too. I hate Microsoft GitHub as much as anyone, but what am I getting from Forgejo or this if instead of fixing the issues with MS GitHub, they are trying to copy everything–including the bad stuff like compatibility with a YAML CI system & the glacial pace of the pull request model where maintainers act entitled rather than just merging shit then fixing their nits. Like, pitch me a CI system that isn’t shit or review that isn’t dogwater like the pull request model & now I’m interested in migration for a better experience rather than just a FOSS clone that doesn’t get you anything better other than a clearer conscience.

    • tengkuizdihar
      link
      fedilink
      arrow-up
      2
      ·
      8 months ago

      rather than just merging shit then fixing their nits do you have something in mind better/more practical? Merging stuff from any contributor without reviews sounds bad.

      • toastal@lemmy.ml
        link
        fedilink
        arrow-up
        3
        arrow-down
        1
        ·
        edit-2
        8 months ago

        You review the ideas & code at a high level. I feel like you didn’t read the “nit” part. Instead I get review for my flyby patch (no plans to be a mainstay) where the idea is fine, but the maintainer wants me to worry about variable names, spacing, & other BS that doesn’t matter. You get a ton of “please add space here” type comments & the maintainer is putting the onus on you to fix their quirks which leads to a really slow review process full of irrelevant nitpicks. A maintainer should just merge that code & fix the nits themselves rather than expecting everyone to care about their naming conventions. Pull request model in an MS GitHub-like UI encourages this behavior.