• fubo@lemmy.world
    link
    fedilink
    arrow-up
    92
    ·
    edit-2
    8 hours ago

    The answer given in the spoiler tag is not quite correct!

    Test case

    According to the spoiler, this shouldn’t match “abab”, but it does.

    Corrected regex

    This will match what the spoiler says: ^.?$|^((.)\2+?)\1+$

    Full workup

    Any Perl-compatible regex can be parsed into a syntax tree using the Common Lisp package CL-PPCRE. So if you already know Common Lisp, you don’t need to learn regex syntax too!

    So let’s put the original regex into CL-PPCRE’s parser. (Note, we have to add a backslash to escape the backslash in the string.) The parser will turn the regex notation into a nice pretty S-expression.

    > (cl-ppcre:parse-string "^.?$|^(..+?)\\1+$")
    (:ALTERNATION
     (:SEQUENCE :START-ANCHOR (:GREEDY-REPETITION 0 1 :EVERYTHING) :END-ANCHOR)
     (:SEQUENCE :START-ANCHOR
      (:REGISTER
       (:SEQUENCE :EVERYTHING (:NON-GREEDY-REPETITION 1 NIL :EVERYTHING)))
      (:GREEDY-REPETITION 1 NIL (:BACK-REFERENCE 1)) :END-ANCHOR))
    

    At which point we can tell it’s tricky because there’s a capturing register using a non-greedy repetition. (That’s the \1 and the +? in the original.)

    The top level is an alternation (the | in the original) and the first branch is pretty simple: it’s just zero or one of any character.

    The second branch is the fun one. It’s looking for two or more repetitions of the captured group, which is itself two or more characters. So, for instance, “aaaa”, or “ababab”, or “abbabba”, but not “aaaaa” or “abba”.

    So strings that this matches will be of non-prime length: zero, one, or a multiple of two numbers 2 or greater.

    But it is not true that it matches only “any character repeated a non-prime number of times” because it also matches composite-length sequences formed by repeating a string of different characters, like “abcabc”.

    If we actually want what the spoiler says — only non-prime repetitions of a single character — then we need to use a second capturing register inside the first. This gives us:

    ^.?$|^((.)\2+?)\1+$.

    Specifically, this replaces (..+?) with ((.)\2+?). The \2 matches the character captured by (.), so the whole regex now needs to see the same character throughout.

      • fubo@lemmy.world
        link
        fedilink
        arrow-up
        12
        ·
        edit-2
        7 hours ago

        Whatever you do, don’t get in a time machine back to 1998 and become a Unix sysadmin.

        (Though we didn’t have CL-PPCRE then. It’s really the best thing that ever happened to regex.)

        • Treczoks@lemmy.world
          link
          fedilink
          arrow-up
          3
          ·
          6 hours ago

          I have to admit that using CL-PPCRE does not really help me understanding the regexp any better. But this may be because I deal with complex regexps for decades now, and I just read them.

      • MalReynolds@slrpnk.net
        link
        fedilink
        English
        arrow-up
        4
        ·
        7 hours ago

        I upvoted you because I consider Perl write only (used to know it, now it inspires readable code as a high priority)

        • Treczoks@lemmy.world
          link
          fedilink
          arrow-up
          7
          ·
          edit-2
          3 hours ago

          Let’s put it this way: You can produce unreadable code in basically any language. With Perl, it is just a bit easier.

          And of course if you have the discipline of a good programmer, even your casual Perl programs should be readable. That’s what differenciates a good programmer from a hacker.

          • MalReynolds@slrpnk.net
            link
            fedilink
            English
            arrow-up
            3
            ·
            4 hours ago

            Yeah, I was younger then, perhaps less disciplined, and as always, given enough work you can decompile or regenerate anything. Still, I contend, the nature of Perl, powerful as it was, lent itself to unmaintainable messes, and I’m not talking regex’s, which is why it has faded, no amount of get gud withstanding.

      • fubo@lemmy.world
        link
        fedilink
        arrow-up
        8
        ·
        6 hours ago

        Regex is good for a few very specific things, and sysadmins used to use it for goddamn everything. If all your server logs are in lightly-structured text files on a small number of servers, being able to improvise regex is damn useful for tracking down server problems. Just write a shell loop that spawns an ssh logging into each server and running grep over the log files, to look for that weird error.

        These days, if you need to crunch production server logs you probably need to improvise in SQL and jq and protobufs or systemd assmonkery or something.

        But if you actually need a parser, for goodness sake use a parser combinator toolkit, don’t roll your own, especially not with regex. Describing your input language in plain Haskell is much nicer than kludging it.

        (This is the “totally serious software engineering advice” forum, right?)