• Admiral Patrick@dubvee.org
    link
    fedilink
    English
    arrow-up
    24
    arrow-down
    1
    ·
    1 month ago

    Just going to leave this horror here. It’s the post feed logic from Tesseract that determines what posts should be displayed or hidden.

    • Alexstarfire@lemmy.world
      link
      fedilink
      arrow-up
      23
      ·
      1 month ago

      If that’s horror to you, you’ve been sheltered. That’s quite readable, though I’d make the long lines into their own subroutines.

    • PoolloverNathan
      link
      fedilink
      arrow-up
      7
      ·
      1 month ago

      Why not factor out the ! via de Morgan’s laws (which would also remove most of the parentheses, as iirc && binds tighter than ||)? Also, does that language have a {#continue} sort of syntax for loops? If so, you could make it a guard clause.

  • Odinkirk@lemmygrad.ml
    link
    fedilink
    arrow-up
    5
    ·
    1 month ago

    That’s why you set the alternate/exit cases as individual if statements before whatever was going to be inside the original if block.

    To me too long to learn that.

      • lad
        link
        fedilink
        English
        arrow-up
        2
        ·
        1 month ago

        Early returns improve readability in that they make it simpler to read, but I also find them decreasing readability in that you may miss an early return and wonder why is execution not hitting the line you expect it to

        • Traister101@lemmy.today
          link
          fedilink
          arrow-up
          3
          ·
          1 month ago

          I’d say in most cases that’s a sign something needs to be extracted into a separate function. Course sometimes code is just complicated and extracting only makes things harder to follow. Even then I’d much rather use early return than nested ifs as those are significantly harder for me to follow.

  • notprogrammer
    link
    fedilink
    arrow-up
    5
    ·
    1 month ago

    But what if I were to add more ‘and’

    It would be extremely painful