• Zagorath@aussie.zoneEnglish
      214·
      1 year ago

      Well, the question sort of implies that you’re needing to implementing Math.max yourself, for whatever reason. Probably as an exercise. It doesn’t make sense to reuse a library that implements the feature if you’re explicitly being asked how you would implement it yourself.

      • Demonen@lemmy.mlEnglish
        161·
        1 year ago

        This is why I think school and interviews are like a whole different universe from the one where actual work gets done.

        • Zagorath@aussie.zoneEnglish
          91·
          1 year ago

          In some ways they can be wholly different, but I don’t think this is a good example of it.

          Any programmer who cannot implement “take two numbers, return the larger one” is clearly not very competent. Even though you’re never going to literally need to implement Math.max yourself at work, you are going to need basically the same types of skills. Probably 95% of the work I do day-to-day is stuff you’d learn in your first year at uni, and this just shows that you’ve got that ability.

          In practice, the best interviews I’ve had usually set a slightly more complicated task as a do-in-your-own-time problem and then go through what you did in the actual interview. Problems like “read a list of names in the form , each name on a separate line, from a text file. Sort the names by last name, then by other names. Output to another text file. Include unit tests.” They wouldn’t then expect you to re-implement the sorting algorithm itself, but more want to look at the quality of code, extensibility, etc.

          More basic questions like the one in the OP, or fizzbuzz, are decent as well, and a big step up from lame questions like “what does SOLID stand for? What does the Liskov substitution principle mean to you?” Even if they’re not quite as valuable as a miniature project.

          • hatchet@sh.itjust.works
            31·
            1 year ago

            I think you can probably make the question a lot more interesting by asking them to implement max without using any branching syntax. I’m not saying that is necessarily a good interview question, but it is certainly more interesting. That might also be where some of the more esoteric answers are coming from.

          • Rodeo@lemmy.ca
            31·
            1 year ago

            In practice, the best interviews I’ve had usually set a slightly more complicated task as a do-in-your-own-time problem and then go through what you did in the actual interview.

            The best interviews you’ve had are the ones where you’re doing free work on your own time?

            • Zagorath@aussie.zoneEnglish
              2·
              1 year ago

              “Work” is a debatable term. It’s not work that provides any direct value to the company, if that’s what you mean. But yes, it involves more effort on my part.

              But yes. Not only does this method let me show that I’m good at what I do (far better than nonsense theory questions do), I have also found that companies that use this approach tend to come across as a better fit in other ways during the interview process.

          • Demonen@lemmy.mlEnglish
            1·
            1 year ago

            For me, a good interview is a dialogue where the company representative shows me as much about the company as I do about me as a candidate. Take-home tasks are okay, I guess, but I suspect they might balk at me requesting they handle a mock HR issue, or whatever, for me!

    • MajorHavoc@lemmy.world
      4·
      1 year ago

      Why would you use anything other than Math.max?

      I mean, I might be being paid by the hour or my performance measured by lines of code…

  • auf@lemmy.ml
    941·
    1 year ago

    Thief way is actually the best among all of these imo, in terms of readability and efficiency.

            • el_abuelo@lemmy.ml
              2·
              1 year ago

              Something has gone horribly wrong if you’re trying to do such optimisations when you’ve already chosen JavaScript…let alone Electron.

                • el_abuelo@lemmy.ml
                  2·
                  1 year ago

                  Thankfully the only interaction I have with teams is when a supplier arranges the call. Once every two weeks. It grosses me out every time…and that’s the Web app.

                  Do you really think they have done such optimisation efforts as minimising function calls? I can’t imagine it’s required for what is actually a fairly simple frontend app. The complexity is the enabling stack on the backend.

            • MajorHavoc@lemmy.world
              1·
              1 year ago

              Good answer.

              Even if it made me throw up in my mouth a little. /s

              Edit: Not the concept of Electron, itself - but being asked to write highly performant code in Electron.

        • Aceticon@lemmy.world
          5·
          1 year ago

          I was under the impression that modern compilers just inline something like that, and even in older languages (like C) use trickeries are used to inline it (typically MAX is a macro rather than a real function, so its always inlined)

          Ultimatelly it depends not just on what you’re doing but also the language and compiler you’re using.

        • Demonen@lemmy.mlEnglish
          3·
          1 year ago

          If you’re optimizing that hard you should probably sort the data first anyway, but yeah, sometimes it’s absolutely called for. Not that I’ve actually needed that in my professional career, but then again I’ve never worked close enough to metal for it to actually matter.

          That said, all of these are implemented as functions, so they’re already costing the function call anyway…

    • snoweA
      232·
      1 year ago

      They’re setting a variable to a function. Just use the original function. All thief does is obfuscate for literally no gain except character count.

  • Leo Uino@lemmy.sdf.org
    77·
    1 year ago

    TDD

    const max12 = (x, y) => {
    if (x === 1 && y === 2) {
        return 2;
    } else if (x === 7 && y === 4) {
        return 7;
    } else {
        return x;
    }
};
  • kewko@lemdro.idEnglish
    31·
    1 year ago

    Mathematician 2 kinda blew my mind, kinda obvious, just can’t believe I was never taught or thought about it.

    • mac@lemm.ee
      3·
      1 year ago

      Lost me when it used Math.abs after calling math.max a their

    • Artyom@lemm.ee
      2·
      1 year ago

      I’ve been staring at it for 10 minutes and I’m still not convinced it works.

      • uberrice@feddit.de
        3·
        1 year ago

        Simple, really. Abs(x-y) is the difference between the two numbers, absolute, so positive value. So, adding abs(x-y) to the smaller of the two numbers turns it into the bigger number. Plus the bigger number, now you have 2 times the bigger number

  • Snazz@lemmy.world
    24·
    1 year ago

    Bit hacker 2 is really fascinating. It uses a bit mask of all 1s (-1) or all 0s (0) and takes advantage of the fact that y ^ (x ^ y) = x and y ^ 0 = y

  • Eufalconimorph@discuss.tchncs.de
    22·
    1 year ago
    #define max(x,y) ( { __auto_type __x = (x); __auto_type __y = (y); __x > __y ? __x : __y; })

    GNU C. Also works with Clang. Avoids evaluating the arguments multiple times. The optimizer will convert the branch into a conditional move, if it doesn’t I’d replace the ternary with the “bit hacker 2” version.

  • force@lemmy.worldEnglish
    275·
    1 year ago

    wtf kind of cursed programming language is this? JS? it’s so ugly, in no universe should a function look like that

    but obviously as a rust enjoyer i have to do it like

    fn max ⟨T: PartialOrd + Copy⟩(nums: ⁊[T]) -> Option⟨T⟩ {
    let mut greatest: ⁊T = ⁊nums[0];
    match nums.len() {
        0 => None,
        1 => Some(*greatest),
        _ => {
            for num in nums {
                if num > greatest {
                    greatest = num;
                }
            }
            Some(*greatest)
        }
    }
}

    edit: lemmy formatting REALLY hates references and generics it seems… time to go back to medieval times

    • stingpie@lemmy.world
      73·
      1 year ago

      Ah yes, rust. The language that somehow manages to manages to as verbose as possible, with as much jargonized shorthand that a computer could handle.

      • aidan@lemmy.world
        2·
        1 year ago

        Exactly, I don’t understand why languages have decided that every keyword needs to be as randomly minified as possible. fn, def, rune(ok that’s not minified, just a dumb name), fmt, std. Many of these things aren’t new, but programmers recognize descriptive variable names are important, the same should be true for keywords.

    • Cihta@lemmy.world
      4·
      1 year ago

      Wow that’s a very exhausting language. I dropped your code into an online rust to asm converter and it actually wasn’t more! I did try to post it for fun but lemmy kept messing up the code block. Oh well, wasn’t that amusing anyway!

      • force@lemmy.world
        4·
        1 year ago

        lol that’s not actually how rust is written, it was just a joke

        it’d really be written

        if x > y { x } else { y }
        • Cihta@lemmy.world
          1·
          1 year ago

          Hah thanks for clarifying. I was joking too and it’s a shame I couldn’t post the results.

          Though I admit i don’t know anything about rust. I’m sure I’d like it better than the proprietary garbage i use now that just gets converted to ASM / PLC code in the end. But I can’t skip the middle man. I’m not gonna try but probably 30mins for me to “write” the above.

          Besides, how do you make money if I can code something in an hour as opposed to 2 days?

            • Cihta@lemmy.world
              3·
              1 year ago

              No no no you misunderstood me.

              I was being honest, I know nothing of rust. I have however used python in embedded systems with positive results. The product didn’t make it but for other reasons.

              Funny you mention java, that’s sorta what I’m stuck in but not like you think. Beyond the fact that it’s a bloated nightmare.

              I’m just a low-level programmer at heart but I have bills to pay. The rust stuff was all just a joke… i don’t know it but maybe i should. Thanks for the info.

              Saying anymore about what I do is just super embarrassing but i promise i meant no ill will. Excuse my frustration, I’m locked into a proprietary system i have no control over. You would laugh your ass off if you saw it. Anyway, i meant no offense, have a good night!

    • neeeeDanke@feddit.de
      1·
      1 year ago

      so 0.3 ~= 1-ln(2)=max(1-ln(2),1-ln(2)) = floor(ln(2*e^(1-ln(2)))) = floor(ln(2)+(1-ln(2))) = 1 ?

      That would bee engeneer 2, not Mathematician3 xD.

      Just out of curiostity, what was you Idea behind that?

      • driving_crooner@lemmy.eco.br
        3·
        1 year ago

        Guess only work with integers, specially for the floor function that is going to give you an integer at the end everytime.

        Not my idea, learned it somewhere while doing college in an statistics class. The idea is that the exponential function grow really fast, so small difference on variables become extreme difference on the exponential, then the log function reverse the exponential, but because it grew more for the biggest variable it reverts to the max variable making the other variables the decimal part (this is why you need the floor function). I think is cool because works for any number of variables, unlike mathematician 2 who only work for 2 variables (maybe it can be generalized for more variables but I don’t think can be done).

        For a min fuction it can be use ceiling(-ln(e^-x + e^-y))

        • neeeeDanke@feddit.de
          2·
          1 year ago

          to be fair it does seem to work for any two numbers where one is >1. As lim x,y–> inf ln(ex+ey) <= lim x,y --> inf ln(2 e^(max(x,y))) = max(x,y) + ln(2).

          I think is cool because works for any number of variables

          using the same proof as before we can see that: lim,x_i -->inf ln(sum_i/in I} e^(x_i)) <= ln(I|) +max{x_i | i /in I.

          So it would only work for at most [base of your log, so e<3 for ln] variables.

            • neeeeDanke@feddit.de
              2·
              1 year ago

              thanks for looking it up:).

              I do think the upper bound on that page is wrong thought. Incedentally in the article itself only the lower bound is prooven, but in its sources this paper prooves what I did in my comment before as well:

              for the upper bound it has max +log(n) . (Section 2, eq 4) This lets us construct an example (see reply to your other comment) to disproove the notion about beeing able to calculate the max for many integers.

          • driving_crooner@lemmy.eco.br
            2·
            1 year ago

            I don’t have a mathematical proof, but doing some experimental tests on excel, using multiple (more than 3) numers and using negative numbers (including only negative numbers) it works perfectly every time.

            • neeeeDanke@feddit.de
              2·
              1 year ago

              Try (100,100,100,100,100,101) or 50 ones and a two, should result in 102 and 4 as a max respectively. I tried using less numbers, but the less numbers you use, the higher the values (to be exact less off a deviation(%-difference) between the values, resulting in higher numbers) have to be and wolframAlpha does not like 10^100 values so I stopped trying.

  • Shhalahr@beehaw.org
    16·
    1 year ago

    Procrastinator.

    Okay, but seriously: “Thief”. Why reimplement it if it’s already available in the language?