This is a really simple silly thing I just realized, but I noticed I have a lot code that looks something like this:

fn foo() -> Result<(), Error> {
    // do something
}

fn bar() -> Option<()> {
    let Ok(f) = foo() else {
        return None;
    };
}

I hated that if-statement. I realized today that I could simplify to:

fn bar() -> Option<()> {
    let f = foo().ok()?;
}

And that cleaned up my code a lot. It’s a tiny thing, but when it’s okay to discard the error from the result, makes such a big difference when you have a lot of them!

  • BB_C
    link
    fedilink
    arrow-up
    4
    ·
    1 year ago

    That is a terrible time to throw away the error. Best to actually check for file not exists error and…

    lol

    This is unintentionally funny considering how exists() is implemented (which is why we have try_exists() now).