This is a really simple silly thing I just realized, but I noticed I have a lot code that looks something like this:

fn foo() -> Result<(), Error> {
    // do something
}

fn bar() -> Option<()> {
    let Ok(f) = foo() else {
        return None;
    };
}

I hated that if-statement. I realized today that I could simplify to:

fn bar() -> Option<()> {
    let f = foo().ok()?;
}

And that cleaned up my code a lot. It’s a tiny thing, but when it’s okay to discard the error from the result, makes such a big difference when you have a lot of them!

  • BB_C
    link
    fedilink
    arrow-up
    4
    ·
    1 year ago

    I don’t get it!

    If the T in Result (and presumably Option) is (), then why not just use is_ok()/is_err() from the caller side?

    Other Tips:

    • bool has then() and then_some() methods in std now.
    • You can transpose() in both directions between ResultOptionᐸTᐳᐳs and OptionResultᐸTᐳᐳs