• kassuro@feddit.de
    link
    fedilink
    arrow-up
    24
    arrow-down
    2
    ·
    1 year ago

    I often have the pleasure of refactoring this mess. And sometimes it’s not just 2 ternaries but like 4 or 5 thrown together. It took like half an hour to even understand what was going on. If you do this, you are just an evil person…

    So I totally support this. Stop this shit…

    • coloredgrayscale
      link
      fedilink
      arrow-up
      10
      ·
      1 year ago

      pleasure of refactoring this mess took half an hour to understand

      If you can use any of the jetBrains IDE it can rewrite it to if/else with a few clicks (or [alt] +[return])

      • kassuro@feddit.de
        link
        fedilink
        arrow-up
        2
        ·
        1 year ago

        Ah that would be helpful. Gotta try that the next time I encounter such a monstrosity.

    • folkrav@lemmy.ca
      link
      fedilink
      arrow-up
      10
      arrow-down
      2
      ·
      1 year ago

      This shit always leaves me wondering who even writes this crap. The answer is more often than not a junior that just discovered code golf thinking he’s oh so clever. You learn to appreciate boring code, with experience…

      • kassuro@feddit.de
        link
        fedilink
        arrow-up
        5
        ·
        1 year ago

        Totally agree with you. I’m always an advocate for boring and easy to understand code.

        I really don’t need an extra layer of complexity just so someone can save a line or two.

    • SatouKazuma@lemmy.world
      link
      fedilink
      arrow-up
      8
      arrow-down
      1
      ·
      1 year ago

      So I’m pretty sure nested ternaries violate one of the Geneva Conventions’ optional protocols.