I was recently tasked with rewriting the base CSS for an inventory/project management system, creating a set of reusable components designed to match, using an open/close approach. These were based on a pretty strict specification provided by one of our designers, who unfortunately left.

The implementation went well, but I’ve run into a bit of a problem. Quite often the team members make changes directly to the base class in the new base CSS file, rather than extending it, creating a new one, or using each system area’s dedicated stylesheet file.

One of the more recent changes involved removing a grid-gap property from a rule from the base CSS, affecting a lot more than the single UI element the team member was working on.

Should I approach the team about this?

I haven’t mentioned anything yet, but have noticed our QA team putting in more bugs about UI elements looking odd

  • half_built_pyramids@lemmy.world
    5·
    10 months ago

    1. passive aggressive email

    2. let qa bust them

    3. collective email reminder to the whole team not to edit the base class, variation of #1

    4. fix it yourself and say nothing, snitches get stitches

    5. snitch

    6. create a copy of the base further down so it just overwrites their changes – I forget if this works, maybe make a copy above too just to cover your angles

    7. ask them to find the bugs in someone else’s commits and see if they fix their own shit

    • William@lemmy.world
      3·
      10 months ago

      Also, I guess it’s a variant of #7: Tell them that their code has caused bugs in existing code and ask them to fix it.

    • ericjmorey
      2·
      10 months ago

      You seem to have a specific set of goals in mind. Please share what those goals are.

      • half_built_pyramids@lemmy.world
        3·
        10 months ago

        Oh, this is like a buffet. Pick and choose. Don’t worry about the conditions back in the kitchen or how we passed our last inspection by wheeling all the expired food out to the dumpster temporarily.