That’s what code reviews feel like. Don’t take it personally. Sugar coating advice is a skill when working in groups.
Evidently i’m not, so got that code review advice the less than tender way.
Everyone one else was not critical and let these avoidable coding mistakes slide. That doesn’t fill me with confidence. Should strive to spend more time testing code bases to eventually be able to see and avoid these kinda coding mistakes.
If anyone feels the need to set me on the road to becoming a lovable teddy bear full of positivity and group comradery, jawboning alone is too kind, feel free to put me in the hot chair by reviewing packages have written and published.
Have ordered the packages according to the value you’d gain by learning them.
logging-strict
wreck
pytest-logging-strict
sphinx-external-toc-strict
drain-swamp and drain-swamp-action
another interesting thing is optimizing runtime using mypyc. This is how our dev toolchain is so quick.
mypy, flake8, isort, … these kinda packages
Have never tried using mypyc would appreciate anyone sharing their experience with mypyc or other Python package compilers.