• @[email protected]
    link
    fedilink
    282 months ago

    yeah I’m gonna go ahead and reject your PR, please change this function to accept a decimal value between 0 and 1

    • @[email protected]
      link
      fedilink
      English
      122 months ago

      Ironically, the worst thing I ever saw a coworker do was to change a function that accepted an Integer value between 0 and 32767 to one that accepted a Float between 0.0 and 1.0. Perfectly sensible change except that it resulted in a 120 mph knuckleball fired a foot above a 10 year old kid’s head, followed by a fist fight between the client and my boss.

      • @[email protected]
        link
        fedilink
        112 months ago

        That sounds like something that should have been caught by QA, integration tests or unit tests long before it was launching balls at ten year olds.

      • @[email protected]
        link
        fedilink
        42 months ago

        yeah every engineer knows you gotta set KidHeadKnuckleballClearance waaay higher than that, it’s compsci 101