Hey all, I made a Firefox extension (signed by Mozilla) specifically to add Show/Hide Child Comments functionality similar to how RES had it (where the parent comment is still visible).

It’s not very useful, but I could use some feedback on tightening up the Javascript. I’m not a JS beginner, but I know I can do better, so any tips are welcome!

EDIT: Also, if anyone has any suggestions for the extension, I’m open to those as well.

  • kn0wmad1cOP
    link
    fedilink
    English
    arrow-up
    3
    ·
    4 months ago

    Hey, just a heads up - I updated the extension to add some rudimentary keyboard navigation. Your j and k are there, and also you can use m to toggle the child comments for the selected comment.

    • Baizey@feddit.dk
      link
      fedilink
      arrow-up
      4
      ·
      edit-2
      4 months ago

      If you wanna tighten up your extension build process feel free to steal my build setup :) (https://github.com/Baizey/UniversalAutomaticCurrencyConverter )

      It’s using esbuild and I’m using it to bundle for both chrome and Firefox separately (they expect slightly different manifest files), has multi entry points support (background, content, options and popup) and builds for ts/js

      • Lemminary@lemmy.world
        link
        fedilink
        arrow-up
        1
        ·
        edit-2
        4 months ago

        bundle for both chrome and Firefox

        You’re a true warrior tolerating that. It gives me headaches.

        E: And you even set up Storybook? Respect.

        • Baizey@feddit.dk
          link
          fedilink
          arrow-up
          2
          ·
          4 months ago

          Oh yeah, but the current manifest v3 difference between Firefox and Chrome is peanuts compared to when I had to have custom logic around regex as they didn’t support the same set of regex specs. Fuck that

      • kn0wmad1cOP
        link
        fedilink
        English
        arrow-up
        1
        ·
        edit-2
        4 months ago

        Your repo made me want to convert the extension to TS, which I’ve never written in before.

        So I did that, and I’m getting to learn a new syntax! Thanks :D