• Kissaki
    link
    fedilink
    English
    arrow-up
    22
    ·
    edit-2
    2 days ago

    "" to '' … There is nothing to highlight for SemanticDiff.

    Really? I definitely want to see that. I want to be deliberate about my code. I am not only targeting compiled code. I am also targeting developers through maintainable code.


    I’m surprised they did not list an alternative that would be my preference: Highlight the entire string. The f prefix changes the entire text value type. I would like the `f´ to be highlighted strongly, and string it changes the interpretation of weakly, and the placeholder variable more strongly again.

    • DarkPlayer@lemmy.worldOP
      link
      fedilink
      arrow-up
      4
      ·
      2 days ago

      Many code formatters decide whether to use " or ' based on some configuration and whether the default one would require escaping. So if you are using such a code formatter, this is no longer a deliberate choice unless you explicitly override the behavior with annotations.

      I am not sure whether your solution of using a less intense color for the unchanged part of the string would make it clearer. It is just more similar to other diff tools that highlight the whole line with a less intense color if it contains changes.

      • Bogasse@lemmy.ml
        link
        fedilink
        arrow-up
        4
        ·
        1 day ago

        Then with a code formatter you definitely want to show this change. In a normal usage the code formatter should ensure that this kind of diff can’t happen, then it’s useful to see if it was not used during a code review.

      • Kissaki
        link
        fedilink
        English
        arrow-up
        2
        ·
        edit-2
        21 hours ago

        would make it clearer

        Would make what clearer?

        If I change a string to a raw string or an interpolated string, it is a semantic change on the entire string, even if it leads to consequential changes only on subsections of it. The next time or additional changes I make must take different semantics into account.

      • Kissaki
        link
        fedilink
        English
        arrow-up
        1
        ·
        21 hours ago

        If the formatting configuration forces one specific style then that is the deliberate choice; to have that one.

        If there is no uniform single string quoting it is useful to differentiate between them; for example if for normal strings ' is preferred while for specific cases where escaping characters like \n is required, " must be used.