• @[email protected]
    link
    fedilink
    English
    2511 months ago

    A quick “find all references” will point out it’s not used and can be deleted if it accidentally gets checked in but ideally, you have systems in place to not let it get checked into the main branch in the first place.

    • Flarp
      link
      fedilink
      2711 months ago

      Yeah that should be looked for in a CI line check, not a compilation requirement

    • @aport
      link
      911 months ago

      You mean a system like the compiler

      • @[email protected]
        link
        fedilink
        14
        edit-2
        11 months ago

        Or a linter. Or code reviews. Or anything else. The nice thing is that if the compiler doesn’t demand something, it can be given to the engineer as an option. The compiler should have the option to do it. The option could even be defaulted on. Afaik there is no way in Golang to disable that error (this is the line that does it: https://github.com/golang/go/blob/04fb929a5b7991ed0945d05ab8015c1721958d82/src/go/types/stmt.go#L67-L69). like --no-pedantics or such. Golang’s compiler openly refuses to give engineers more choices in what they think is the best system to handle it.

        • @aport
          link
          -511 months ago

          Who needs an option to leave unused variables around the code base? Lazybones?

          • @[email protected]
            link
            fedilink
            511 months ago

            You’ve literally never commented out a line or two but left the variable declaration while debugging?

    • @[email protected]
      link
      fedilink
      English
      5
      edit-2
      11 months ago

      Yeah any compiler should support environments or config files. Our CI would never work with without --env “stage”