• lowleveldata
    link
    fedilink
    arrow-up
    3
    arrow-down
    2
    ·
    5 months ago

    And then everyone will make those whitespace PRs because they want to say they have contributed in XYZ big name projects in their CVs. I don’t see why we should encourage those people.

    • JackbyDev
      link
      fedilink
      English
      arrow-up
      1
      ·
      5 months ago

      If you genuinely find a white space problem in a project go ahead and submit a patch, by all means. Let the other devs focus on more pressing problems.

        • JackbyDev
          link
          fedilink
          English
          arrow-up
          1
          ·
          5 months ago

          Having devs outside of the project submit fixes for minor issues that don’t require intimate knowledge of the project itself is spending dev effort better than having the project devs themselves have to do it.

          • lowleveldata
            link
            fedilink
            arrow-up
            2
            arrow-down
            1
            ·
            5 months ago

            Having people really outside of the project to commit to the repo is a bad idea to begin with. If you don’t plan to contribute by code then just don’t contribute at all.

            • JackbyDev
              link
              fedilink
              English
              arrow-up
              1
              ·
              5 months ago

              They aren’t commiting to the project, they’re submitting pull requests. Totally different.

              • lowleveldata
                link
                fedilink
                arrow-up
                1
                ·
                5 months ago

                Ya. I mean their commits shouldn’t be merged to the repo. They can of course commit whatever they want to their own fork.