Replace OIDN denoiser in Lightmapper with a JNLM denoiser compute shader. by DarioSamo · Pull Request #81659 · godotengine/godot
github.com
Original proposal: godotengine/godot-proposals#7640 Background "Nonlinearly Weighted First-order Regression for Denoising Monte Carlo Renderings" (https://benedikt-bitterli.me/nfor/nfor.pdf) mentio...

TL;DR:

Before:

An image showcasing the old de-noiser

After:

An image showcasing the new de-noiser

These images are 2 weeks old and there have been some changes to it, as well as a slider to adjust de-noising. Notice how much more pronounced the ambient occlusion is, and how much better the overall shading is. It’s also faster than the older implementation.

On the scene I used for testing this out, the overall rendering time went down from 3 minutes to just over 1 minute in an RTX 3090 Ti with an 8K lightmap.

Bonus: This PR shaves off a massive chunk of the codebase (about 10% apparently.) Expect faster build times and a smaller engine size in 4.2!

An image showing a diff of +304 and -114,449

  • I Cast FistEnglish
    12·
    1 year ago

    Holy shit, 114k lines of code being blown away? That has to be some sort of record for efficiency gain.

    I’m interested in comparative gains for lower-specs scenes, like 1k lightmap. Also, was that gain on Vulkan? Have you checked OpenGL 2 and 3, or it won’t work with them?

    • popcar2OP
      2·
      1 year ago

      I’m pretty sure this was on Vulkan, I’m not sure how it is for the compatibility renderer since many things about it isn’t finished for 3D.