From a site I’ve inherited which is full of things like this (and lots of other very !important things). Send help.

  • key@lemmy.keychat.org
    link
    fedilink
    English
    arrow-up
    63
    ·
    10 months ago

    That’s why css names should be semantic. I’m sure it started actually purple until UX said “can we make this primary text more blue so it doesn’t look like a clicked link?” Replacing all references to “purple” wasn’t an option because of unrelated usage of that word elsewhere and they weren’t using an IDE capable of contextual rename of a css class. So they just changed the color code and called it a day.

        • activ8r@sh.itjust.works
          link
          fedilink
          English
          arrow-up
          4
          ·
          10 months ago

          It’s fine as long as you have proper source control. Run it and check the diff before committing.

          • lars@lemmy.sdf.org
            link
            fedilink
            English
            arrow-up
            1
            ·
            edit-2
            10 months ago

            But I set my .git directories to have .css filename extensions!!?! It shouldn’t be my job to educate you.

      • FoxBJK@midwest.social
        link
        fedilink
        English
        arrow-up
        3
        ·
        10 months ago

        Gotta do it on the HTML files and JS files too. Then you gotta re-test every page that uses those files.

        Then the boss looks over your code and asks why you didn’t just change the actual color because that’s easier to QC.

    • HollandJim@lemmy.world
      link
      fedilink
      English
      arrow-up
      2
      arrow-down
      4
      ·
      edit-2
      10 months ago

      Yeah, but if you just used css variables, this would’ve been a doddle. One and done.

      I’m sorry but the solution to every argument is not just to throw of the word “semantic” in the sentence. Context is everything.

      • Victor@lemmy.world
        link
        fedilink
        English
        arrow-up
        6
        ·
        edit-2
        10 months ago

        I’m sorry but the solution to every argument is not just to throw of the word “semantic” in the sentence.

        I’m sorry but who is saying that? Nobody is. If you are paying attention to the context, you will notice they are talking about CSS class names. That’s the context, and it’s a valid point within that context.

  • moog@lemm.ee
    link
    fedilink
    English
    arrow-up
    10
    ·
    10 months ago

    Why is a color class also changing the display to inline is what I wanna know

    • ndru@lemmy.worldOP
      link
      fedilink
      English
      arrow-up
      4
      ·
      10 months ago

      Tip of the iceberg. I’m perplexed about every 30 minutes working on this codebase.

    • SebKra@feddit.de
      link
      fedilink
      English
      arrow-up
      2
      ·
      10 months ago

      My guess is that this tactical tornado here didn’t know the difference between a span and a div

  • I Cast Fist
    link
    fedilink
    English
    arrow-up
    4
    ·
    10 months ago

    Send help.

    Set up something to change all fonts to Comic Sans before you leave. That’s all the help I can offer you, OP