• jadero
        link
        fedilink
        arrow-up
        20
        arrow-down
        1
        ·
        9 months ago

        There was a thread elsewhere asking whether a toggle should show current state or the state desired. There was enough disagreement that it quickly became apparent that, whatever else the toggle does, there should be something external to the toggle showing the possible states, indicating which way to move the toggle regardless of toggle appearance.

        • The disagreement was actually all over whether the question was about a switch or a button, and so some people were answering as though it was a switch, and some people were answering as though it was a button - switches and buttons do indeed have opposite approaches usually (a switch usually shows the current state - such as “on” - but a button shows what action will be triggered by pressing it, such as “play”).

        • starman
          link
          fedilink
          English
          arrow-up
          4
          ·
          edit-2
          9 months ago

          There was a thread elsewhere asking whether a toggle should show current state or the state desired.

          there it is

        • snoweMA
          link
          fedilink
          arrow-up
          4
          ·
          9 months ago

          that post is about toggle buttons, not switches. e.g. a play pause button, when pressed, does it show play, or does it show pause?

          • jadero
            link
            fedilink
            arrow-up
            2
            ·
            9 months ago

            Oops! I guess I wasn’t paying close enough attention.

            • snoweMA
              link
              fedilink
              arrow-up
              2
              ·
              9 months ago

              still, people are clearly confused by the button. I’m just gonna make it an animation and prefers-color-scheme since that’s so widely supported now.

        • Feathercrown@lemmy.world
          link
          fedilink
          English
          arrow-up
          2
          ·
          9 months ago

          It really depends on the type of control and what it’s controlling. As this is a switch, you’d expect the current state to be what’s shown on the same side as the slider-- in this case, the slider is a sun in dark mode and a moon in light mode, which is the opposite way.

      • qaz@lemmy.world
        link
        fedilink
        arrow-up
        8
        ·
        9 months ago

        It did nothing when clicking it the first time and only changed the second time I clicked it

        • snoweMA
          link
          fedilink
          arrow-up
          6
          ·
          9 months ago

          I’ve wondered what this problem was for years but never cared to figure it out, because it always resolved after the first button press (just refresh the page and it all works properly). turns out it is something wrong with my use of local storage to save your theme state. if you don’t have the key in local storage then it does what you mentioned. I just need to switch this to prefers-color-scheme anyway.

      • fd93
        link
        fedilink
        arrow-up
        2
        ·
        9 months ago

        Hey - the poster isn’t actually the author. That would be me! Thanks for the feedback though. I normally just use Dark Reader for switching theme.

      • snoweMA
        link
        fedilink
        arrow-up
        2
        ·
        9 months ago

        Hm. what browser are you on? It is showing sun for me on light mode.

        • im sorry i broke the code@sh.itjust.works
          link
          fedilink
          arrow-up
          3
          ·
          edit-2
          9 months ago

          It works if you visited the website already but the first time it breaks: reloading fixes this while emptying the caches breaks it again. As another user pointed out the first click after emptying the cache doesn’t do anything at all even though the animation plays out just fine

          EDIT: I’m on safari ios, latest stable (17.3.1 if I’m not mistaken)