If you admit it’s a minor nitpick then you should be expecting to get rejected. Dev effort is better spent on real features than merging those whilespace PRs.
And then everyone will make those whitespace PRs because they want to say they have contributed in XYZ big name projects in their CVs. I don’t see why we should encourage those people.
If you genuinely find a white space problem in a project go ahead and submit a patch, by all means. Let the other devs focus on more pressing problems.
Having devs outside of the project submit fixes for minor issues that don’t require intimate knowledge of the project itself is spending dev effort better than having the project devs themselves have to do it.
Having people really outside of the project to commit to the repo is a bad idea to begin with. If you don’t plan to contribute by code then just don’t contribute at all.
If you admit it’s a minor nitpick then you should be expecting to get rejected. Dev effort is better spent on real features than merging those whilespace PRs.
It would’ve taken less time to merge this than the original comment denying it took to write.
And then everyone will make those whitespace PRs because they want to say they have contributed in XYZ big name projects in their CVs. I don’t see why we should encourage those people.
If you genuinely find a white space problem in a project go ahead and submit a patch, by all means. Let the other devs focus on more pressing problems.
Let’s agree to disagree
Having devs outside of the project submit fixes for minor issues that don’t require intimate knowledge of the project itself is spending dev effort better than having the project devs themselves have to do it.
Having people really outside of the project to commit to the repo is a bad idea to begin with. If you don’t plan to contribute by code then just don’t contribute at all.
They aren’t commiting to the project, they’re submitting pull requests. Totally different.
Ya. I mean their commits shouldn’t be merged to the repo. They can of course commit whatever they want to their own fork.