verstra to Programmer Humor · 11 hours ago10000 line PR? LGTM, loli.imgflip.comimagemessage-square15fedilinkarrow-up1133arrow-down14file-text
arrow-up1129arrow-down1image10000 line PR? LGTM, loli.imgflip.comverstra to Programmer Humor · 11 hours agomessage-square15fedilinkfile-text
minus-squareverstraOPlinkfedilinkarrow-up16arrow-down4·10 hours agoNo it is not. It depends on the codebase - if it is something relatively new, a proof of concept or something that is bound to change soon, there is no point in slowing the development down just because it is “too large to digest”.
minus-squareEndmaker@ani.sociallinkfedilinkEnglisharrow-up7·9 hours agoThen saying that you have looked through and reviewed the code would be lying. And that is unprofessional.
minus-squareDudeDudenson@lemmings.worldlinkfedilinkarrow-up6·9 hours agoIs sitting down and understanding the code in the PR not an option?
minus-squareEndmaker@ani.sociallinkfedilinkEnglisharrow-up3·9 hours agoI’m not sure what you are getting at.
No it is not. It depends on the codebase - if it is something relatively new, a proof of concept or something that is bound to change soon, there is no point in slowing the development down just because it is “too large to digest”.
Then saying that you have looked through and reviewed the code would be lying. And that is unprofessional.
Is sitting down and understanding the code in the PR not an option?
I’m not sure what you are getting at.
Clearly they hate efficiencies.