If it compiles it works, right?

I’m not gonna act like I read it all.

  • GissaMittJobb@lemmy.ml
    link
    fedilink
    arrow-up
    13
    ·
    11 hours ago

    The correct response to any PR that is too large to digest is to reject it and ask the author to split it up.

    • verstraOP
      link
      fedilink
      arrow-up
      16
      arrow-down
      4
      ·
      11 hours ago

      No it is not. It depends on the codebase - if it is something relatively new, a proof of concept or something that is bound to change soon, there is no point in slowing the development down just because it is “too large to digest”.

    • gnutrino
      link
      fedilink
      English
      arrow-up
      2
      arrow-down
      1
      ·
      edit-2
      11 hours ago

      Sure but who’s got time for all that aggravation? Especially if it’s not part of the codebase I have to work with personally. LGTM and let it be someone else’s problem.