• GissaMittJobb@lemmy.ml
    702·
    10 months ago

    Having an asterisk both be the type indicator and the dereference operator is one of the great programming language design blunders of our time, along with allowing nulls for any type in so many languages.

    • darkpanda@lemmy.ca
      20·
      10 months ago

      I also sometimes wish that the syntax in if statements was inverted, where () was optional and {} was required.

        • noli
          9·
          10 months ago

          if(condition) statement; Is valid in typical C-style syntax.

          if condition { … }

          Is invalid in typical C-style syntax

        • darkpanda@lemmy.ca
          6·
          10 months ago

          The code in the image is C or C++ or similar. In those languages and languages derived from them, curly braces are optional but the parentheses are required. It should be the other way around to avoid logic errors like this:

          if (some expression)
  doSomething()
else if (some other expression)
  printf(“some debugging code that’s only here temporarily”);
  doSomethingElse();

          Based on the indentation you’d think that doSomethingElse was only meant to run if the else if condition was true, but because of the lack of braces and the printf it actually happens regardless of either of the if conditions. This can sometimes lead to logic errors and it doesn’t hold up to a principle of durability under edit — that is, inserting some code into the if statement changes the outcome entirely because it changes the code path entirely, so the code is in a sense fragile to edits. If the curly braces were required instead of optional, this wouldn’t happen.

          I have all of my linters set up to flag a lack of curly braces in these languages as an error because of this. It’s a topic that sometimes causes some debate, ‘cause some people will vociferously defend their right to not have the braces there for one liners and more compact code, but I have found that in general having them be required consistently has led to fewer issues than having arguments about their absence, but to each their own. I know many big projects that have the opposite stance or have other guidelines, but I just make ‘em required on my own projects or projects that I’m in charge of and be done with it.

  • blackstrat@lemmy.fwgx.uk
    657·
    10 months ago

    The fact it’s a pointer is part of the type, not part of the variable name. So int* p is the way.

    • sweng
      892·
      10 months ago

      You would think so, but int* a, b is actually eqivalent to int* a; int b, so the asterisk actually does go with the name. Writing int* a, *b is inconsistent, so int *a, *b is the way to go.

      • newH0pe@feddit.de
        571·
        10 months ago

        Yeah, and I’d say that’s a design flaw of the language as it is unintuitive behaviour.

      • Slotos@feddit.nl
        38·
        10 months ago

        When people say “pointers are hard”, they mean “I have no idea where the star goes and now an ampersand is also implicated”.

      • blackstrat@lemmy.fwgx.uk
        25·
        10 months ago

        While technically true, that’s also one of the worst ‘features’ of the language and I personally consider it a bug in the language. Use two lines and make it clear and correct.

      • Gladaed@feddit.de
        172·
        10 months ago

        Don’t declare more than 1 pointer per line. This resolves that, badly.

    • sham1@sopuli.xyz
      171·
      10 months ago

      Then again, at least in C, the mantra is “declaration follows usage”. Surely you don’t write pointer dereferences as * ptr? Most likely not, you most likely write it as *ptr. The idea behind the int *ptr; syntax is basically that when you do *ptr, you get an int.

      And with this idea, stuff like function pointers (int (*f)(void)), arrays of pointers (int *a[10]) versus pointers of arrays (int (*a)[10]) etc. start making sense. It’s certainly not the best way to design the syntax, and I’m as much a fan of the Pascal-styled “type follows the identifier” syntax (e.g. let x: number;) as anyone, but the C way does have a rhyme and a reason for the way it is.

    • Traister101@lemmy.today
      6·
      10 months ago

      It’s part of the type yet it’s also a unique identifier. That’s the whole thing with east or west const. const int * is a immutable mutable pointer that points to mutable immutable memory. int *const is a mutable immutable pointer that points to immutable memory. int const * is the same type as the first example, a immutable mutable pointer that points to mutable immutable memory.

      Same stuff applies to references which makes it easier to think of the variable owning the * or & as if you want that pointer or reference to be const it has to go after.

      Edit:I am a moron who managed to get it exactly backwards :|

        • SpaceNoodle@lemmy.world
          4·
          10 months ago

          I wrote a couple unholy lines of C++ the other day using the ternary conditional operator to select a class member function to be called with a fixed argument.

          I think my teammates were too scared to call me out on it.

            • SpaceNoodle@lemmy.world
              3·
              10 months ago

              It’s actually simpler than doing it the “right” way, but I wanted to see how much I could make C++ pretend it was Python.

      • YaBoyMaxEnglish
        3·
        10 months ago

        I think you’ve got it backwards. I learned to read pointer decls from right-to-left, so const int * is a (mutable) pointer to an int which is const while int *const is a const pointer to a (mutable) int.

    • Scoopta
      51·
      10 months ago

      I do this in my code because it looks better and makes more sense…until I decide to declare 2 vars on one line and then I use the very cursed int* a, *b

    • owsei@lemmy.world
      41·
      10 months ago

      tbh I always think about it as ‘p’ is a pointer to int

      therefore *p is an int

      therefore I should call it int *p;

      however, of course, you should use what your team prefers. Having good yet inconsistent style is worst than mid consistent style.

    • ShortFuse@lemmy.world
      31·
      10 months ago

      I don’t code much C++, but then I’d lose alignment with: x = *p; and I feel that would bug me.

      I’m looking at Google Style Guide for my next project and it says either is fine, just don’t declare more than one per line.

  • dbilitated@aussie.zone
    161·
    10 months ago

    I’m just a c# dev wishing to fuck we had something visual to indicate reference types so my coworkers could stop misusing them

  • RandomCookie420@eviltoast.orgEnglish
    43·
    10 months ago

    Ever written a entire php in one line? I did, and that without separation whenever possible.

    Man my coworker even ended the trolling contest over that.

    • Ferk@kbin.social
      121·
      10 months ago

      But C syntax clearly hints to int *p being the expected format.

      Otherwise you would only need to do int* p, q to declare two pointers… however doing that only declares p as pointer. You are actually required to type * in front of each variable name intended to hold a pointer in the declaration: int *p, *q;