• mspencer712
    90·
    2 months ago

    Remove these blank lines.

    I’m not seeing unit tests for this.

    Unnecessary comment.

    BLAM

    Ow! Also, this could’ve been a smaller calibur.

  • steventhedev@lemmy.world
    441·
    2 months ago

    I have either written or gotten a variant of every single one of these comments 🫠:

    Please include the JIRA task in the commit title.

    Did you run any manual testing?

    Where’s the PRD link in the commit message?

    Can you please split this into multiple smaller commits?

    Can you combine these two commits?

    Did you email Jon about this because he’s working on that project with Sarah and you might be duplicating efforts.

    This should be named BarFoo instead of FooBar.

    Why aren’t you using CorporateInternalLib16 that does 90% of this?

    Why aren’t you using ThirdPartyPaidLibByExEmployee?

    Why aren’t you using StandardLib thing you forgot existed?

    All our I/O should be async.

    All our hot loop code needs to be sync.

    This will increase latency of NonCoreBusinessFlow by 0.01%. can you shave some time off so we can push in feature B also?

    Please add a feature flag so we can do gradual rollout.

    What operational levers does this have?

    Lgtm - just address those comments

    • expr
      26·
      2 months ago

      I dunno, plenty of those sound pretty reasonable.

      • frezik@midwest.social
        2·
        2 months ago

        Mostly, yes.

        I’d like to find a better way to phrase "why aren’t you . . . " questions. It carries an accusatory tone in text, even if you don’t intend that. The answer is almost invariably going to be either “I didn’t know it existed” or “because reason X”. Neither case justifies the accusatory tone. Maybe if the “I didn’t know it existed” answer was something so basic that they really should have known it existed, but probably not even then.

        • Thinker@lemmy.world
          3·
          2 months ago

          My preferred variation of this is to make it an open question that leaves them in the position of authority, and assumes that they made a deliberate decision.

          For example, instead of “Why aren’t you using StandardLib that does 90% of this?”, I would try “Could this be achieved with StandardLib? Seems like it would cover 90% of this”.

          • skulbuny@sh.itjust.worksEnglish
            3·
            2 months ago

            If you have seniority and they are a junior, some juniors do respond well to a senior having more knowledge about the codebase. With them, it can be beneficial to use a tone like “We have library X that seems like it could do a lot of the functionality here, unless you already took a look?” I know it’s like 90% of the same but I know people who will just be shellshocked and just blindly say “yes” to any question you ask them, and I don’t want a blind “yes” I wanna know the truth :) it also lets then explain why they didn’t use it if they have a legit reason because hey, maybe I’m the one who needs to be caught up

  • SavvyWolf@pawb.socialEnglish
    22·
    2 months ago

    “Did you run the formatter on this?”

    Bonus points if it’s python code and nowhere in the docs does it say which of the many formatters to use.

      • bob_lemon@feddit.org
        5·
        2 months ago

        I’m fond of ruff lately. Pretty much the same as black, but it just comes with the linter instead of being separate tools.

        • Gamma@beehaw.orgEnglish
          2·
          2 months ago

          👀 I’d fine-tuned (copied and pasted) a pylint setup that had some of black, what are the differences?

          Edit: it’s so much faster than black, I’m switching

          Edit2: used it today, faster and I like the linter. It also does some multi-line parentheses better imo

  • ngn@lemy.lolEnglish
    7·
    2 months ago

    i don’t understand it, am i missing some context here?

    • pixelscript@lemm.eeEnglish
      25·
      2 months ago

      The meme format implies she catfished you with the promise of “Netflix and chill” at her house only to pull a gun on you.

      In particular, she wants you to review and merge that goddamn pull request she made to your open source project repo two months ago that finally fixes that one really annoying bug.

  • whoisearth@lemmy.ca
    5·
    2 months ago

    First problem is she’s expecting a right boob like me to review her pull request. Second problem is I don’t give a shit.