curl https://some-url | sh

I see this all over the place nowadays, even in communities that, I would think, should be security conscious. How is that safe? What’s stopping the downloaded script from wiping my home directory? If you use this, how can you feel comfortable?

I understand that we have the same problems with the installed application, even if it was downloaded and installed manually. But I feel the bar for making a mistake in a shell script is much lower than in whatever language the main application is written. Don’t we have something better than “sh” for this? Something with less power to do harm?

  • ulterno
    link
    fedilink
    English
    arrow-up
    0
    arrow-down
    1
    ·
    3 hours ago

    I don’t cringe. Just instinctively Ctrl+W

  • Artyom@lemm.ee
    link
    fedilink
    arrow-up
    18
    ·
    9 hours ago

    What’s stopping the downloaded script from wiping my home directory?

    What’s stopping any Makefile, build script, or executable from running rm -rf ~? The correct answer is “nothing”. PPAs are similarly open, things are a little safer if you only use your distro’s default package sources, but it’s always possible that a program will want to be able to delete something in your home directory, so it always has permission.

    Containerized apps are the only way around this, where they get their own home directory.

    • easily3667@lemmus.org
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      1 hour ago

      Don’t forget your package manager, running someone’s installer as root

      It’s roughly the same state as when windows vista rolled out UAC in 2007 and everything still required admin rights because that’s just how everything worked…but unlike Microsoft, Linux distros never did the thing of splitting off installs into admin vs unprivileged user installers.

  • tatterdemalion
    link
    fedilink
    arrow-up
    8
    arrow-down
    3
    ·
    10 hours ago

    Back up your data folks. You’re probably more likely to accidentally rm -rf yourself than download a script that will do it.

    • easily3667@lemmus.org
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      1 hour ago

      To be fair that’s because Linux funnels you to the safeguard-free terminal where it’s much harder to visualize what’s going on and fewer checks to make sure you’re doing what you mean to be doing. I know it’s been a trend for a long time where software devs think they are immune from mistakes but…they aren’t. And nor is anyone else.

  • thomask@lemmy.sdf.org
    link
    fedilink
    English
    arrow-up
    13
    arrow-down
    2
    ·
    edit-2
    16 hours ago

    The security concerns are often overblown. The bigger problem for me is I don’t know what kind of mess it’s going to make or whether I can undo it. If it’s a .deb or even a tarball to extract in /usr/local then I know how to uninstall.

    I will still use them sometimes but for things I know and understand - e.g. rustup will put things in ~/.rustup and update the PATH in my shell profile and because I know that’s what it does I’m happy to use the automation on a new system.

      • FizzyOrange
        link
        fedilink
        arrow-up
        1
        arrow-down
        1
        ·
        3 hours ago

        No it isn’t. What could a Bash script do that the executable it downloads couldn’t do?

        • jagged_circle@feddit.nl
          link
          fedilink
          English
          arrow-up
          1
          ·
          edit-2
          8 minutes ago

          You’re telling me that you dont verify the signatures of the binaries you download before running them too?!? God help you.

          I download my binaries with apt, which will refuse to install the binary if the signature doesn’t match.

        • easily3667@lemmus.org
          link
          fedilink
          English
          arrow-up
          1
          ·
          edit-2
          1 hour ago

          By definition nothing

          The point you appear to be making is “everything is insecure so nothing is” and the point others are making is “everything is insecure so everything is”

      • thomask@lemmy.sdf.org
        link
        fedilink
        English
        arrow-up
        9
        ·
        edit-2
        11 hours ago

        So tell me: if I download and run a bash script over https, or a .deb file over https and then install it, why is the former a “security nightmare” and the latter not?

        • jagged_circle@feddit.nl
          link
          fedilink
          English
          arrow-up
          1
          ·
          5 minutes ago

          Both are a security nightmare, if you’re not verifying the signature.

          You should verify the signature of all things you download before running it. Be it a bash script or a .deb file or a .AppImage or to-be-compiled sourcecode.

          Best thing is to just use your Repo’s package manager. Apt will not run anything that isn’t properly signed by a package team members release PGP key.

        • rocky_patriot
          link
          fedilink
          English
          arrow-up
          1
          ·
          1 hour ago

          For example: A compromised host could detect whether you are downloading the script or piping it.

  • ikidd@lemmy.world
    link
    fedilink
    English
    arrow-up
    5
    arrow-down
    1
    ·
    16 hours ago

    When I modded some subreddits I had an automod rule that would target curl-bash pipes in comments and posts, and remove them. I took a fair bit of heat over that, but I wasn’t backing down.

    I had a lot of respect for Tteck and had a couple discussions with him about that and why I was doing that. I saw that eventually he put a notice up that pretty much said what I did about understanding what a script does, and how the URL you use can be pointed to something else entirely long after the commandline is posted.

  • knexcar@lemmy.world
    link
    fedilink
    English
    arrow-up
    3
    ·
    16 hours ago

    What does curl even do? Unstraighten? Seems like any other command I’d blindly paste from an internet thread into a terminal window to try to get something on Linux to work.

    • irelephant [he/him]🍭@lemm.ee
      link
      fedilink
      English
      arrow-up
      2
      ·
      8 hours ago

      curl sends requests, curl lemmy.world would return the html of lemmy.worlds homepage. piping it into bash means that you are fetching a shell script, and running it.

      • easily3667@lemmus.org
        link
        fedilink
        English
        arrow-up
        1
        ·
        edit-2
        1 hour ago

        I think he knows but is commenting on the pathetic state of security culture on Linux. (“Linux is secure so I can do anything without concerns”)

      • billwashere@lemmy.world
        link
        fedilink
        English
        arrow-up
        4
        ·
        17 hours ago

        Yeah I guess if they were being especially nefarious they could supply two different scripts based on user-agent. But I meant what you said anyways… :) I download and then read through the script. I know this is a common thing and people are wary of doing it, but has anyone ever heard of there being something disreputable in one of this scripts? I personally haven’t yet.

        • Possibly linux@lemmy.zip
          link
          fedilink
          English
          arrow-up
          2
          ·
          16 hours ago

          I’ve seen it many times. It usually takes the form of fake websites that are impersonating the real thing. It is easy to manipulate Google results. Also, there have been a few cases where a bad design and a typo result in data loss.

  • lemmeBe@sh.itjust.works
    link
    fedilink
    arrow-up
    25
    arrow-down
    2
    ·
    1 day ago

    I think safer approach is to:

    1. Download the script first, review its contents, and then execute.
    2. Ensure the URL uses HTTPS to reduce the risk of man-in-the-middle attacks
    • jagged_circle@feddit.nl
      link
      fedilink
      English
      arrow-up
      3
      ·
      12 hours ago

      Key being reduce. Https doesn’t protect from loads of attacks. Best to verify the sig.

      If its not signed, open a bug report

      • Dr. Moose@lemmy.world
        link
        fedilink
        English
        arrow-up
        1
        arrow-down
        1
        ·
        16 hours ago

        But then they’d have to lay some guy 15$ to package it and thats like, spending money

            • Possibly linux@lemmy.zip
              link
              fedilink
              English
              arrow-up
              2
              arrow-down
              2
              ·
              4 hours ago

              That’s how you end up with a secure well tested system. Having the distro do software reviews adds another level of validation. Devs are bad about shipping software with vulnerable dependencies and stuff like that.

          • Dr. Moose@lemmy.world
            link
            fedilink
            English
            arrow-up
            1
            ·
            12 hours ago

            Loads of distros have user packing like arch and nixos… also many distors accept donations to package your software either way so my point stands even then.

    • Steve Dice@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      14
      ·
      23 hours ago

      If you’ve downloaded and audited the script, there’s no reason to pipe it from curl to sh, just run it. No https necessary.

      • isaaclw@lemmy.world
        link
        fedilink
        arrow-up
        3
        arrow-down
        2
        ·
        18 hours ago

        The https is to cover the factthat you might have missed something.

        I guess I download and skim out of principle, but they might have hidden something in there.

        • Steve Dice@sh.itjust.works
          link
          fedilink
          English
          arrow-up
          3
          ·
          16 hours ago

          Wat. All https does is encrypt the connection when downloading. If you’ve already downloaded the file to audit it, then it’s in your drive, no need to use curl to download it again and then pipe it to sh. Just click the thing.

  • zygo_histo_morpheus
    link
    fedilink
    arrow-up
    81
    arrow-down
    4
    ·
    1 day ago

    You have the option of piping it into a file instead, inspecting that file for yourself and then running it, or running it in some sandboxed environment. Ultimately though, if you are downloading software over the internet you have to place a certain amount of trust in the person your downloading the software from. Even if you’re absolutely sure that the download script doesn’t wipe your home directory, you’re going to have to run the program at some point and it could just as easily wipe your home directory at that point instead.

    • cschreibOP
      link
      fedilink
      arrow-up
      7
      ·
      24 hours ago

      Indeed, looking at the content of the script before running it is what I do if there is no alternative. But some of these scripts are awfully complex, and manually parsing the odd bash stuff is a pain, when all I want to know is : 1) what URL are you downloading stuff from? 2) where are you going to install the stuff?

      As for running the program, I would trust it more than a random deployment script. People usually place more emphasis on testing the former, not so much the latter.

    • rah@feddit.uk
      link
      fedilink
      English
      arrow-up
      3
      arrow-down
      2
      ·
      edit-2
      1 day ago

      You have the option of piping it into a file instead, inspecting that file for yourself and then running it, or running it in some sandboxed environment.

      That’s not what projects recommend though. Many recommend piping the output of an HTTP transfer over the public Internet directly into a shell interpreter. Even just

      curl https://... > install.sh; sh install.sh
      

      would be one step up. The absolute minimum recommendation IMHO should be

      curl https://... > install.sh; less install.sh; sh install.sh
      

      but this is still problematic.

      Ultimately, installing software is a labourious process which requires care, attention and the informed use of GPG. It shouldn’t be simplified for convenience.

      Also, FYI, the word “option” implies that I’m somehow restricted to a limited set of options in how I can use my GNU/Linux computer which is not the case.

      • gaylord_fartmaster@lemmy.world
        link
        fedilink
        arrow-up
        5
        arrow-down
        1
        ·
        18 hours ago

        Showing people that are running curl piped to bash the script they are about to run doesn’t really accomplish anything. If they can read bash and want to review the script then they can by just opening the URL, and the people that aren’t doing that don’t care what’s in the script, so why waste their time with it?

        Do you think most users installing software from the AUR are actually reading the pkgbuilds? I’d guess it’s a pretty small percentage that do.

        • rah@feddit.uk
          link
          fedilink
          English
          arrow-up
          1
          arrow-down
          1
          ·
          edit-2
          4 hours ago

          Showing people that are running curl piped to bash the script they are about to run doesn’t really accomplish anything. If they can read bash and want to review the script then they can by just opening the URL

          What it accomplishes is providing the instructions (i.e. an easily copy-and-pastable terminal command) for people to do exactly that.

          • gaylord_fartmaster@lemmy.world
            link
            fedilink
            arrow-up
            2
            ·
            3 hours ago

            If you can’t review a bash script before running it without having an unnecessarily complex one-liner provided to you to do so, then it doesn’t matter because you aren’t going to be able to adequately review a bash script anyway.

      • zygo_histo_morpheus
        link
        fedilink
        arrow-up
        2
        arrow-down
        3
        ·
        1 day ago

        I mean if you think that it’s bad for linux culture because you’re teaching newbies the wrong lessons, fair enough.

        My point is that most people can parse that they’re essentially asking you to run some commands at a url, and if you have even a fairly basic grasp of linux it’s easy to do that in whatever way you want. I don’t know if I personally would be any happier if people took the time to lecture me on safety habits, because I can interpret the command for myself. curl https://some-url | sh is terse and to the point, and I know not to take it completely literally.

        • rah@feddit.uk
          link
          fedilink
          English
          arrow-up
          4
          arrow-down
          1
          ·
          1 day ago

          linux culture

          snigger

          you’re teaching newbies the wrong lessons

          The problem is not that it’s teaching bad lessons, it’s that it’s actually doing bad things.

          most people can parse that they’re essentially asking you to run some commands at a url

          I know not to take it completely literally

          Then it needn’t be written literally.

          I think you’re giving the authors of such installation instructions too much credit. I think they intend people to take it literally. I think this because I’ve argued with many of them.

  • serenissi@lemmy.world
    link
    fedilink
    arrow-up
    18
    arrow-down
    3
    ·
    1 day ago

    Unpopular opinion, these are handy for quickly installing in a new vm or container (usually throwaway) where one don’t have to think much unless the script breaks. People don’t install thing on host or production multiple times, so anything installed there is usually vetted and most of the times from trusted sources like distro repos.

    For normal threat model, it is not much different from downloading compiled binary from somewhere other than well trusted repos. Windows software ecosystem is famously infamous for exactly the same but it sticks around still.

  • Undaunted@feddit.org
    link
    fedilink
    arrow-up
    21
    arrow-down
    1
    ·
    1 day ago

    You shouldn’t install software from someone you don’t trust anyway because even if the installation process is save, the software itself can do whatever it has permission to.

    “So if you trust their software, why not their install script?” you might ask. Well, it is detectable on server side, if you download the script or pipe it into a shell. So even if the vendor it trustworthy, there could be a malicious middle man, that gives you the original and harmless script, when you download it, and serves you a malicious one when you pipe it into your shell.

    And I think this is not obvious and very scary.

    • August27th@lemmy.ca
      link
      fedilink
      arrow-up
      8
      ·
      1 day ago

      it is detectable […] server side, if you download the script [vs] pipe it into a shell

      I presume you mean if you download the script in a browser, vs using curl to retrieve it, where presumably you are piping it to a shell. Because yeah, the user agent is going to reveal which tool downloaded it, of course. You can use curl to simply retrieve the file without executing it though.

      Or are you suggesting that curl makes something different in its request to the server for the file, depending on whether it is saving the file to disk vs streaming it to a pipe?

    • FizzyOrange
      link
      fedilink
      arrow-up
      5
      arrow-down
      4
      ·
      edit-2
      20 hours ago

      it is detectable on server side, if you download the script or pipe it into a shell

      Irrelevant. This is just an excuse people use to try and win the argument after it is pointed out to them that there’s actually no security issue with curl | bash.

      It’s waaaay easier to hide malicious code in a binary than it is in a Bash script.

      You can still see the “hidden” shell script that is served for Bash - just pipe it through tee and then into Bash.

      Can anyone even find one single instance of that trick ever actually being used in the wild (not as a demo)?

      • Undaunted@feddit.org
        link
        fedilink
        arrow-up
        4
        ·
        20 hours ago

        I never tried to win any argument. Hell I was not even aware that I’m participating in one. I just wanted to share the info, that even if the vendor is absolutely trustworthy and even if you validated the script by downloading and looking at it, there’s still another hole that’s not obvious to see.

        Yes it’s unlikely, but again, I never said it were. There are also arguments you can run curl with, to tell it to do the download first and then push it through the pipe afterwards, though I don’t know them by heart now.

        It won’t cost you anything to set those parameters, when you insist to use curl | bash, just in the off chance that someone’s trying to do what I mentioned.

        But I’m also someone who usually validates their downloads with a checksum so maybe I’m just weird. Who knows.